[jdk25u-dev] RFR: 8365065: cancelled ForkJoinPool tasks no longer throw CancellationException
Roland Mesde
duke at openjdk.org
Wed Dec 3 18:54:03 UTC 2025
On Wed, 3 Dec 2025 11:57:54 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:
>> Backporting JDK-8365065: Cancelled ForkJoinPool tasks no longer throw CancellationException. Fixes the exception propagation and tests. Based on the original bug it is a regression and it last worked in version 17.0.16. Ran GHA Sanity Checks (passed), jtreg tier1 tests (passed) and related tests (passed) on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
>>
>> (Passed) - make test-tier1
>> (Passed) - make test TEST=test/jdk/java/util/concurrent
>>
>> Results are attached.
>>
>> [linux-aarch64-jtreg-tier1.log](https://github.com/user-attachments/files/23776572/linux-aarch64-jtreg-tier1.log)
>> [linux-aarch64-specific-test.log](https://github.com/user-attachments/files/23776573/linux-aarch64-specific-test.log)
>> [linux-x64-jtreg-tier1.log](https://github.com/user-attachments/files/23776574/linux-x64-jtreg-tier1.log)
>> [linux-x64-specific-test.log](https://github.com/user-attachments/files/23776575/linux-x64-specific-test.log)
>> [macos-aarch64-jtreg-tier1.log](https://github.com/user-attachments/files/23776576/macos-aarch64-jtreg-tier1.log)
>> [macos-aarch64-specific-test.log](https://github.com/user-attachments/files/23776577/macos-aarch64-specific-test.log)
>> [windows-x64-jtreg-tier1.log](https://github.com/user-attachments/files/23776578/windows-x64-jtreg-tier1.log)
>> [windows-x64-specific-test.log](https://github.com/user-attachments/files/23776579/windows-x64-specific-test.log)
>
> Hi @rm-gh-8
> Please supply sufficient approval request comments.
> Read https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix thoroughly please! Expecially 6 ii)
> You need to talk about:
> *Why you backport. Why should the change go to the update release (No, not because it fixes the bug!)
> *The risk of breaking anything, especially running applications that obtain an update.
> *Short description of how you backported (clean? trivial edit? other changes included?)
> *Clean is only clean if Skara says so!
> *Short test overview.
> This goes to the JBS issue, it needs to make sense there. If you repeat the title of the bug that's quite pointless.
>
> I will silently remove the fix request labels if the approval comment does not help me to assess the backport. Later, I might just reject them.
@GoeLin I edited the existing approval comments on the other PRs pending approval.
Before I proceed with this current PR. It is modifying the exception propagation back to be compliant with the specification, but it does make a modification in the javadoc. Is expectation to remove the javadoc comment changes from the backport so it just entails behavioral changes?
-------------
PR Comment: https://git.openjdk.org/jdk25u-dev/pull/3#issuecomment-3608320852
More information about the jdk-updates-dev
mailing list