[jdk17u-dev] RFR: 8311663: Additional refactoring of Locale tests to JUnit

[Ralf Schmelter]

On Thu, 9 Jan 2025 10:42:34 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> test/jdk/java/util/Locale/Bug8135061.java
> test/jdk/java/util/Locale/Bug8159420.java
> test/jdk/java/util/Locale/ThaiGov.java
> 
> These three need to be resolved because
> "8283698: Refactor Locale constructors used in src/test" is not in 17.
> Basically I took over the head version of the test in 21, and reverted the refactored constructor call.
> 
> test/jdk/java/util/Locale/UseOldISOCodesTest.java
> 
> is not in 17. It was added by "8295232: "java.locale.useOldISOCodes" property is read lazily".
> As I understand the error fixed by JDK-8295232 was introduced by closed JDK-8294667. I built
> jdk20 before JDK-8295232 was pushed, this causes the test to fail.
> With 17 and 20 after this change it passes.  I would like to take the test to 17 to
> improve testing along with this change. This would also alert us if a change breaking 
> this is backported.
> As with the changes above I had to undo JDK-8283698.

Looks good.,

Looks good.

-------------

Marked as reviewed by rschmelter (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/3196#pullrequestreview-2547287010
PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3196#issuecomment-2587706759