[jdk17u-dev] Integrated: 8311663: Additional refactoring of Locale tests to JUnit
Goetz Lindenmaier
goetz at openjdk.org
Tue Jan 14 13:31:57 UTC 2025
On Thu, 9 Jan 2025 10:42:34 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:
> test/jdk/java/util/Locale/Bug8135061.java
> test/jdk/java/util/Locale/Bug8159420.java
> test/jdk/java/util/Locale/ThaiGov.java
>
> These three need to be resolved because
> "8283698: Refactor Locale constructors used in src/test" is not in 17.
> Basically I took over the head version of the test in 21, and reverted the refactored constructor call.
>
> test/jdk/java/util/Locale/UseOldISOCodesTest.java
>
> is not in 17. It was added by "8295232: "java.locale.useOldISOCodes" property is read lazily".
> As I understand the error fixed by JDK-8295232 was introduced by closed JDK-8294667. I built
> jdk20 before JDK-8295232 was pushed, this causes the test to fail.
> With 17 and 20 after this change it passes. I would like to take the test to 17 to
> improve testing along with this change. This would also alert us if a change breaking
> this is backported.
> As with the changes above I had to undo JDK-8283698.
This pull request has now been integrated.
Changeset: 10e109d2
Author: Goetz Lindenmaier <goetz at openjdk.org>
URL: https://git.openjdk.org/jdk17u-dev/commit/10e109d200d3ae3c19d5da9130cdc9215a32816f
Stats: 594 lines in 10 files changed: 211 ins; 216 del; 167 mod
8311663: Additional refactoring of Locale tests to JUnit
Reviewed-by: rschmelter
Backport-of: 71cac8ce47b69a2b78d54cbceb0f0510e5ea4cdc
-------------
PR: https://git.openjdk.org/jdk17u-dev/pull/3196
More information about the jdk-updates-dev
mailing list