[jdk17u-dev] RFR: 8294399: (ch) Refactor some methods out of sun.nio.ch.UnixFileDispatcherImpl
Galder Zamarreño
galder at openjdk.org
Wed Jul 2 09:46:44 UTC 2025
On Wed, 11 Jun 2025 14:08:10 GMT, Shruthi <duke at openjdk.org> wrote:
> Signed-off-by: Shruthi [Shruthi.Shruthi1 at ibm.com](mailto:Shruthi.Shruthi1 at ibm.com)
>
> OpenJDK PR : https://github.com/openjdk/jdk/pull/10434
> OpenJDK bug : https://bugs.openjdk.org/browse/JDK-8294399
>
> The original patch does not apply cleanly to JDK17u-dev, as UnixFileDispatcherImpl.java and UnixFileDispatcherImpl.c do not exist in this version.
> Instead, JDK 17 uses FileDispatcherImpl.java and FileDispatcherImpl.c under the unix directory for the relevant implementation.
> Therefore, the changes were applied manually to align with the JDK 17 structure.
The changes look fine to me. The changes that were originally `UnixFileDispatcherImpl.[java/c]` align with the ones in `FileDispatcherImpl.[java/c]`.
What testing have you done to validate the changes? Once that is explained and validated I'll approve.
-------------
PR Review: https://git.openjdk.org/jdk17u-dev/pull/3631#pullrequestreview-2978485680
More information about the jdk-updates-dev
mailing list