[jdk21u-dev] RFR: 8357882: Use UTF-8 encoded data in LocaleDataTest
Richard Reingruber
rrich at openjdk.org
Sat Nov 1 06:12:05 UTC 2025
On Tue, 21 Oct 2025 20:13:32 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:
> I backport this for parity with 21.0.10-oracle.
>
> The change does not apply well.
> The cldr test data file underwent several changes in head.
> Manual resolving is not a good approach here.
> Instead, I converted the file with the shell printf command. I verified it is identical
> in several places withoutb conflicts. I also looked at places with conflicts that they look good now.
>
> The test also needed resolves due to context.
>
> Further, the test in 21 excercises two runs, one using a file for the COMPAT version that was removed in 25.
> I adapted this as above, too.
>
> I guess this is a true jewel for reviewers ... but keep in mind, it's only a test change :)
I've done the conversion myself with a little python script and got the same result.
So looks good!
Cheers, Richard.
-------------
Marked as reviewed by rrich (Reviewer).
PR Review: https://git.openjdk.org/jdk21u-dev/pull/2371#pullrequestreview-3406888504
More information about the jdk-updates-dev
mailing list