[jdk17u-dev] RFR: 8294314: Minimize disabled warnings in hotspot [v3]
Sergey Bylokhov
serb at openjdk.org
Thu Nov 6 22:21:15 UTC 2025
On Mon, 3 Nov 2025 08:56:37 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Sergey Bylokhov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Drop non-existent in 17u file
>
> make/hotspot/lib/CompileJvm.gmk line 178:
>
>> 176: DISABLED_WARNINGS_gcc_shenandoahBarrierSetC1.cpp := misleading-indentation, \
>> 177: DISABLED_WARNINGS_gcc_signals_posix.cpp := cast-function-type, \
>> 178: DISABLED_WARNINGS_gcc_templateTable.cpp := cast-function-type, \
>
> I think we can drop this line, as https://github.com/openjdk/jdk/commit/fc616588c1bf731150a9d9b80033bb589bcb231f just got backported. The line above it (signals_posix.cpp) would probably also go away after https://github.com/openjdk/jdk17u-dev/pull/4125.
The patch has been [updated](https://github.com/openjdk/jdk17u-dev/pull/4143/commits/d4f4fb1d2537bcaed55c05d255d9eeb95ebdd77b). It now includes the following changes in `CompileJvm.gmk`:
- https://github.com/openjdk/jdk/commit/fc616588c1bf731150a9d9b80033bb589bcb231f, which was not part of the backport for [jdk17u-dev](https://github.com/openjdk/jdk17u-dev/commit/98532ee9fd5136d7d21025941845e77ae216377a)
- https://github.com/openjdk/jdk/commit/b06f1b149c8f8a49d4e42c4b782a4b3a22aa79f6, which was also not part of the backport [jdk17u-dev](https://github.com/openjdk/jdk17u-dev/commit/a3442fd77f524a2ccbb499ab0120b11c30642708)
-------------
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/4143#discussion_r2501040607
More information about the jdk-updates-dev
mailing list