[jdk17u-dev] RFR: 8294314: Minimize disabled warnings in hotspot [v3]

[Aleksey Shipilev]

On Fri, 31 Oct 2025 23:10:05 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit [7743345f](https://github.com/openjdk/jdk/commit/7743345f6f73398f280fd18364b4cea10a6b0f2f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>> 
>> The commit being backported was authored by Magnus Ihse Bursie on 17 Oct 2022 and was reviewed by Erik Joelsson and Aleksey Shipilev.
>> 
>> The patch updates the code to handle certain warnings during compilation. It is part of the ongoing effort to migrate JDK 17 to the new toolchain, including Xcode 16, and will make further patches cleaner.
>> 
>> The patch is not clean because the next three are not in jdk17u:
>>  - https://bugs.openjdk.org/browse/JDK-8286262 -> still need to disable [4996](https://github.com/openjdk/jdk17u-dev/pull/4143/commits/e1b33bcab3a09bcdf16ea6bd740d4ffbf00adaab) warning
>>  - https://bugs.openjdk.org/browse/JDK-8293182 -> still need to disable [missing-field-initializers](https://github.com/openjdk/jdk17u-dev/pull/4143/commits/32855c2267dd796d82893f39e82592dc68fef3c6)
>>  - https://bugs.openjdk.org/browse/JDK-8303805 -> still need to disable [strict-overflow](https://github.com/openjdk/jdk17u-dev/pull/4143/commits/9f8b0126e9c0d3f1a0e83a2fe722f3996c8dcb41)
>> 
>> The next two are are already in jdk17u so context a little bit different:
>>  - https://bugs.openjdk.org/browse/JDK-8300169
>>  - https://bugs.openjdk.org/browse/JDK-8319818
>> 
>> 
>> Testing:
>>  - github actions
>>  - gcc: 7.3.1, 9.3.1, 10.5.0, 11.4.0, 11.5.0, 13.2.1 and 13.3.0
>>  - xcode: 26, 26.0.1
>>  - VS 2022
>
> Sergey Bylokhov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Drop non-existent in 17u file

Looks fine to me, good job! I think we'll wait for another PR to land, upgrade to MacOS 15, and then see if this exclusion block is fine for all GHA platforms. How does that sound?

make/hotspot/lib/CompileJvm.gmk line 178:

> 176:     DISABLED_WARNINGS_gcc_shenandoahBarrierSetC1.cpp := misleading-indentation, \
> 177:     DISABLED_WARNINGS_gcc_signals_posix.cpp := cast-function-type, \
> 178:     DISABLED_WARNINGS_gcc_templateTable.cpp := cast-function-type, \

I think we can drop this line, as https://github.com/openjdk/jdk/commit/fc616588c1bf731150a9d9b80033bb589bcb231f just got backported. The line above it (signals_posix.cpp) would probably also go away after https://github.com/openjdk/jdk17u-dev/pull/4125.

-------------

PR Review: https://git.openjdk.org/jdk17u-dev/pull/4143#pullrequestreview-3410004109
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/4143#discussion_r2485732907