[jdk25u-dev] RFR: 8360702: runtime/Thread/AsyncExceptionTest.java timed out
Goetz Lindenmaier
goetz at openjdk.org
Fri Feb 20 10:14:47 UTC 2026
On Wed, 18 Feb 2026 17:26:41 GMT, Roland Mesde <duke at openjdk.org> wrote:
>> The PR is not clean, because it misses the change from the original commit:
>>
>>
>> - * @requires test.thread.factory == null
>>
>>
>> Do you know what is up with that?
>
>> The PR is not clean, because it misses the change from the original commit:
>>
>> ```
>> - * @requires test.thread.factory == null
>> ```
>>
>> Do you know what is up with that?
>
> My understanding is that "@requires test.thread.factory == null" means the test will only run when no custom thread factory is configured. In both cases, the result is the removal of the section, which should be considered trivial in nature due to the final result, which complies with the intent of the commit.
@rm-gh-8
please remark in your fix request that the change was not clean (just the fact, not why).
The comment in the PR should say what had to be changed.
Thanks.
-------------
PR Comment: https://git.openjdk.org/jdk25u-dev/pull/274#issuecomment-3932843352
More information about the jdk-updates-dev
mailing list