[jdk25u-dev] RFR: 8360702: runtime/Thread/AsyncExceptionTest.java timed out
Roland Mesde
duke at openjdk.org
Fri Feb 20 16:23:52 UTC 2026
On Fri, 20 Feb 2026 10:12:17 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:
>>> The PR is not clean, because it misses the change from the original commit:
>>>
>>> ```
>>> - * @requires test.thread.factory == null
>>> ```
>>>
>>> Do you know what is up with that?
>>
>> My understanding is that "@requires test.thread.factory == null" means the test will only run when no custom thread factory is configured. In both cases, the result is the removal of the section, which should be considered trivial in nature due to the final result, which complies with the intent of the commit.
>
> @rm-gh-8
> please remark in your fix request that the change was not clean (just the fact, not why).
> The comment in the PR should say what had to be changed.
> Thanks.
@GoeLin I updated the PR description with a full explanation of the conflict. I hope that works. Please let me know if you want to tackle the larger dependency graph mentioned. In that case, I will withdraw this PR.
-------------
PR Comment: https://git.openjdk.org/jdk25u-dev/pull/274#issuecomment-3935849257
More information about the jdk-updates-dev
mailing list