Update on JDK 10 repo consolidation; third generation prototype coming soon, September 2017 still the target

David Holmes david.holmes at oracle.com
Wed Sep 6 02:18:29 UTC 2017


On 6/09/2017 12:02 PM, Weijun Wang wrote:
> So there is no plan to deal with multiple ProblemList.txt files and groups defined in multiple TEST.groups?

I for one would not want to see the test directory flattened. I want to 
be able to focus on hotspot tests, or jdk tests, or whatever tests. Many 
of the hotspot tests would not make sense in a flattened layout - you 
would have no idea what they pertain to. I prefer to see the tests kept 
in functional groups.

That said I would think it possible to define a top-level test/TEST.ROOT 
etc that allows all the underlying tests to be combined as needed.

Cheers,
David

> Thanks
> Max
> 
>> On Sep 6, 2017, at 9:20 AM, joe darcy <joe.darcy at oracle.com> wrote:
>>
>> Hi Max,
>>
>>
>> On 9/5/2017 4:47 PM, Weijun Wang wrote:
>>>> On Sep 1, 2017, at 10:00 AM, joe darcy <joe.darcy at oracle.com> wrote:
>>>>
>>>> One of the infra-related items planned to be worked on is a patch conversion script analogous to (and perhaps sharing implementation with) the shuffle script used for the Jigsaw changes.
>>> In fact, if the test directory is flattened (i.e. no more test/jdk), then there will be no need for a shuffle script. At least this is true for patches for the jdk sub-repo.
>>
>> As noted in the current text of the JEP, "As a consequence [of combining all the module src directories from each repo into consolidated directory], from the root of the repository the relative path of a source file in a module is preserved after the consolidation and src directory combination."
>>
>> Therefore, it is true that no relative path change needs to occur in the forward direction. However, if backporting a patch from a the consolidated repo to the split forest, multiple patches may need to be created.
>>
>> However, there are many more logistical issues and fewer concrete benefits from combining all the tests together. Additionally, the tests lack the strict module-based structure present under the src directory. For example, most tests today in core libs are are arranged by package rather than by module.
>>
>> Consequently, I don't think a wholesale rearrangement of the test is warranted at this time as part of repo consolidatoin, but I'd encourage teams to examine the structure of tests in their own areas.
>>
>> Thanks,
>>
>> -Joe
> 


More information about the jdk10-dev mailing list