Regression test /java/util/logging/LoggingDeadlock2 in OpenJDK6 is not correct

[Andrew John Hughes]

2009/12/4 Andrew John Hughes <gnu_andrew at member.fsf.org>:
> 2009/12/4 Pavel Tisnovsky <ptisnovs at redhat.com>:
>> Hi,
>>
>> Regression test /java/util/logging/LoggingDeadlock2 in OpenJDK6 does not
>>  work correctly. As I see, the fix for this test has already been applied in
>> OpenJDK7. Is it possible to backport this new version to OpenJDK6, please? I
>> successfully tested this new version against OpenJDK6 without problems.
>>
>> Thank you in advance
>> Pavel Tisnovsky
>>
>
> There are two relevant fixes for this test in 7:
>
> changeset:   1282:7772d77bd7c2
> parent:      1280:045aeb76b0ff
> user:        mchung
> date:        Tue May 26 17:47:57 2009 -0700
> summary:     6829636: test/java/util/logging/LoggingDeadlock2.java is flaky
>
> changeset:   1163:079985c9965b
> user:        martin
> date:        Mon Apr 20 21:53:38 2009 -0700
> summary:     6716076: test
> UTIL_REGRESSION/test/java/util/logging/LoggingDeadlock2.java failed
> with exit code 1
>
> I guess we should backport both to stabilise this test.
> --
> Andrew :-)
>
> Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
>
> Support Free Java!
> Contribute to GNU Classpath and the OpenJDK
> http://www.gnu.org/software/classpath
> http://openjdk.java.net
>
> PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
> Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8
>


The webrev for the backport of Martin's changeset is at:

http://cr.openjdk.java.net/~andrew/6716076/webrev.01/

Is this ok to push?

I'm not sure how relevant the other changeset is.  It only removes an
ignore line from the test, which isn't present in the OpenJDK6 version
(it's introduced by an earlier changeset from Kelly).  It includes
some other changes to URLConnection which the bug report
(http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6829636) doesn't
explain.  The bug report does however refer to another bug related to
ShutdownHooks.  Would someone care to shed some light on this bug?
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8