Security fixes are back; other fixes can go in. Time for build 18?

[Joseph D. Darcy]

Andrew John Hughes wrote:
> 2009/12/8 Jonathan Gibbons <Jonathan.Gibbons at sun.com>:
>   
>> Joseph D. Darcy wrote:
>>     
>>> Andrew John Hughes wrote:
>>>       
>>>> 2009/12/8 Jonathan Gibbons <Jonathan.Gibbons at sun.com>:
>>>>
>>>>         
>>>>> Andrew John Hughes wrote:
>>>>>
>>>>>           
>>>>>> Finally, during build, I just spotted another issue.  The langtools
>>>>>> build wrongly passes -Werror to javac and this has been removed in the
>>>>>> OpenJDK7 version.  It only shows up if you build OpenJDK6 with
>>>>>> OpenJDK7, so it's minor but probably worth fixing.  I doubt that is
>>>>>> the only building-with-7 issue though.
>>>>>>
>>>>>>
>>>>>>             
>>>>> langtools is supposed to be warning free and thus is supposed to use
>>>>> -Werror.
>>>>>
>>>>> -- Jon
>>>>>
>>>>>
>>>>>           
>>>> Not according to this changeset of yours:
>>>>
>>>> http://hg.openjdk.java.net/jdk7/jdk7/langtools/rev/12c9e612e9e31
>>>>
>>>>         
>>> The removal of Werror from langtools in JDK 7 was a transitory change; it
>>> came back as part of Jon's subsequent changset:
>>>
>>> http://hg.openjdk.java.net/jdk7/jdk7/langtools/rev/b4b1f7732289
>>>
>>> -Joe
>>>       
>> When the langtools repository was originally created, there were different
>> coding standards for different tools, with the bar being higher for some
>> than for others. That is why at that time we could not use -Werror for all
>> tools.  Once we finally made the entire repository warning-free, it made
>> sense to impose -Werror as a check that we maintained that level.
>>
>> -- Jon
>>
>>     
>
> I'm glad the code is Werror free.  Those of us working on IcedTea are
> certainly aware that the rest of the JDK code certainly isn't; when we
> bootstrap with ecj some 14k warnings are thrown out from the OpenJDK
> code (ecj is much more noisy by default) leading to -nowarn being
> added.
>
> The issue here is that the -Werror bit is in OpenJDK6 but the actual
> fix is not.  It's strange because -unchecked seems to be being passed,
> yet unchecked warnings are being thrown.
>   

The JDK 7 compiler does a better check of checking for unchecked problems.

After the voluminous thread yesterday, my sense is that :

* It is not appropriate or necessary to backport the javap rewrite to 
OpenJDK 6.
* Having the OpenJDK 6 langtools code be able to pass through the JDK 7 
compiler under Werror would at most be a "nice to have" feature.
* Using the JDK 7 compiler to perform full bootstrap cycle for OpenJDK 6 
is impractical because it uses a new class file format not understood by 
Java SE 6 compilers.

-Joe