Backport request (was Re: 6712755: jarsigner fails to sign itextasian.jar since 1.5.0_b14, it works with 1.5.0_13)

[Max (Weijun) Wang]

On Dec 24, 2009, at 9:13 AM, Martin Buchholz wrote:

> On Wed, Dec 23, 2009 at 16:59, Max (Weijun) Wang  
> <Weijun.Wang at sun.com> wrote:
>> Well, without the -strict option, warning is not error, and the  
>> test cannot
>> prove the fix.
>
> Hmmm... yes.
>
> It appears that the warning is only written to stdout, not stderr,
> so can't use that to test for failure.
>
> Here's another attempt, that I have tested to ensure it
> fails without and passes with, the fix, which should be good enough
> at least for this backport.
>
> $JARSIGNER -keystore $KS -verify -debug $JFILE 2>&1 | grep Warning  
> && exit 2

This should be fine.

Max

>
> Martin
>
>> Max
>>
>> On Dec 24, 2009, at 8:54 AM, Martin Buchholz wrote:
>>
>>> On Wed, Dec 23, 2009 at 16:45, Martin Buchholz <martinrb at google.com>
>>> wrote:
>>>>
>>>> On Wed, Dec 23, 2009 at 16:10, Max (Weijun) Wang <Weijun.Wang at sun.com 
>>>> >
>>>> wrote:
>>>>>
>>>>> Joe
>>>>>
>>>>> 6712755 is a regression made by 6543940.
>>>>>
>>>>>              openjdk-7     openjdk-6
>>>>>  6712755     b16           included
>>>>>  6543940     b64           not included
>>>>>
>>>>> Martin, do you want to do the backport yourself?
>>>>
>>>> It's already "done".
>>>> All I did was
>>>> (cd jdk7/jdk && hg export ...) | (cd jdk6/jdk && hg qimport -n  
>>>> jarsigner
>>>> -)
>>>
>>> Hmmmm..... I have to retract that.
>>>
>>> The new test didn't pass, because
>>> the jdk6 jarsigner doesn't recognize the jdk7 option "-strict"
>>> Removing "-strict" make the test pass.
>>>
>>> Martin
>>>
>>>> Martin
>>>>
>>>>> Thanks
>>>>> Max
>>>>>
>>>>> On Dec 24, 2009, at 7:47 AM, Martin Buchholz wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> We've found that the fix for
>>>>>> 6712755: jarsigner fails to sign itextasian.jar since  
>>>>>> 1.5.0_b14, it
>>>>>> works with 1.5.0_13
>>>>>> is a good thing to have in openjdk6.
>>>>>> Permission to do the trivial backport?
>>>>>>
>>>>>>     jarsigner chokes on empty lines in MANIFEST.MF files.
>>>>>>
>>>>>>     Backport from openjdk7 of:
>>>>>>     # HG changeset patch
>>>>>>     # User weijun
>>>>>>     # Date 1245294733 -28800
>>>>>>     # Node ID 863351d5d244ad4077a9b8db87bb9f186ce76f76
>>>>>>     # Parent bc2c9dbdcc704deab9466581d32f5fc011c5b8d1
>>>>>>     6712755: jarsigner fails to sign itextasian.jar since  
>>>>>> 1.5.0_b14, it
>>>>>>     works with 1.5.0_13
>>>>>>     Reviewed-by: mullan
>>>>>>
>>>>>>     http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/863351d5d244
>>>>>>
>>>>>>     http://bugs.sun.com/view_bug.do?bug_id=6712755
>>>>>
>>>>>
>>>>
>>
>>