HotSpot 16 and OpenJDK6

[Erik Trimble]

Joe Darcy wrote:
> Andrew John Hughes wrote:
>> On 23 February 2010 20:10, Joseph D. Darcy <Joe.Darcy at sun.com> wrote:
>>  
>>> Hello.
>>>
>>> Andrew John Hughes wrote:
>>>    
>>>> Here's the merge:
>>>>
>>>> http://cr.openjdk.java.net/~andrew/jdk6-hs16-merge/webrev.01/
>>>>
>>>> which now builds, thanks to this additional changeset from Daniel
>>>> Daugherty in baseline:
>>>> http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/c9740f5ed5b4
>>>>
>>>>       
>>> Good.
>>>
>>>    
>>>> It also includes an additional fix, also listed separately at:
>>>>
>>>> http://cr.openjdk.java.net/~andrew/jdk6-hs16-merge/webrev.02/
>>>>
>>>> which reverts an erroneous change from SIZE_FORMAT to %d in
>>>>
>>>> changeset:   734:dbbe28fc66b5
>>>> user:        twisti
>>>> date:        Fri Feb 27 03:35:40 2009 -0800
>>>> summary:     6778669: Patch from Red Hat -- fixes compilation errors
>>>>
>>>> fixing the build on x86_64.  We'll need a bug ID for this reversion.
>>>>
>>>>       
>>> The webrev generally looks good, but I have a few questions and 
>>> comments
>>> before this goes back.
>>>
>>> Do you know why webrev shows so many files with zero changes?  I 
>>> assume this
>>> is an artifact of the merge.
>>>
>>>     
>>
>> No, you're right that does seem strange.  All I did was a pull from
>> hs16 and then a merge.  Perhaps this is some webrev oddity?
>>
>> If you look at 
>> http://mail.openjdk.java.net/pipermail/jdk6-dev/2010-February/001230.html 
>>
>> I included a diff of the merged OpenJDK6 against the hs16 master
>> (which includes Daniel's patch that is currently only in baseline).
>> It actually makes the other questions below a bit clearer.
>>   
>
> Yes, that patch size is more manageable!
>
>>  
>>> In hotspot_version, what are the semantics of JDK_PREVIOUS_VERSION?
>>>
>>>     
>>
>> I'm not sure.  It doesn't seem to do much.  Its only use is to set a
>> default BOOTDIR AFAICS:
>>
>> # Find JDK used for javac compiles
>> BOOTDIR=$(SLASH_JAVA)/re/j2se/$(PREVIOUS_JDK_VERSION)/latest/binaries/$(PLATFORM) 
>>
>>
>> (from hotspot/make/defs.make)
>>
>> We actually differ from hs16 by still using 1.5.0 rather than 1.6.0.
>> 1.5.0 implicitly seems to make more sense to me, because 1.6.0 is the
>> version being built.  But in practice, it doesn't seem to matter
>> unless you're relying on the contents of a /java tree.
>>   
>
> I have a vague recollection of there being a particular reason why 
> this was upgraded to 1.6.0 so I'd prefer to see this kept as 1.6.0.
>

I'll have to go back and check, but there were some changes around 6u14 
which required that the build JDK for Hotspot be at least 1.6-something.



-- 
Erik Trimble
Java System Support
Mailstop:  usca22-123
Phone:  x17195
Santa Clara, CA