Need reviewers for changes in java/net regression tests

[Chris Hegarty]

On 07/26/10 13:33, Pavel Tisnovsky wrote:
> .....
>
> Hi Chris,
>
> I mean the difference between (for example) these changes:
> http://cr.openjdk.java.net/~ptisnovs/JavaNetJTregTests/test/java/net/DatagramSocket/DatagramTimeout.java.cdiff.html
>
> and
> http://cr.openjdk.java.net/~ptisnovs/JavaNetJTregTests/test/java/net/Inet6Address/serialize/Serialize.java.cdiff.html
>
> In the first case there's only minimal (I said "cosmetic") changes, not
> new test functionality, but in the case there's new functionality added
> to the test (test for regression for another bug).

What we want to backport are only the changes to the tests that improve 
the test themselves. What you have called 'cosmetic' changes. Additional 
functionality, and additional tests, have been added to JDK7 to test 
specific bugs that have been fixed in that release. These are not 
applicable to 6 Open and I don't see that we should try to backport these.

The 'cosmetic' changes fix issues like fixed port numbers ( problems 
when more than one instance of the test is running), samevm issues ( not 
cleaning up after the test ), and a test issues themselves. These 
changes should provide a better, more reliable, test bed.

-Chris.

>>
>> -Chris.
>>
>>>
>>>>
>>>> -Chris.
>>>>
>>>> On 07/23/10 12:20, Pavel Tisnovsky wrote:
>>>>> Hi,
>>>>>
>>>>> I tried to backport more regression tests from OpenJDK7 to OpenJDK6.
>>>>> Webrev with changes is available at:
>>>>> http://cr.openjdk.java.net/~ptisnovs/JavaNetJTregTests/
>>>>>
>>>>> Can anyone please review the changes?
>>>>>
>>>>> There are still minor differences between OpenJDK6 and OpenJDK7
>>>>> tests, mainly due to syntax enhancements in OpenJDK7.
>>>>>
>>>>> Please note that new test case (deserialization an Inet6 address with
>>>>> a named interface) is included in
>>>>> Inet6Address/serialize/Serialize.java regression test:
>>>>> http://cr.openjdk.java.net/~ptisnovs/JavaNetJTregTests/test/java/net/Inet6Address/serialize/Serialize.java.cdiff.html
>>>>>
>>>>>
>>>>>
>>>>> This issue which was fixed in OpenJDK7 but not in OpenJDK6 yet. Btw -
>>>>> do anyone know, if this issue will be fixed in OpenJDK6?
>>>>>
>>>>> The changes made in these test are really minor and they are based
>>>>> (but
>>>>> not equal) on changes done by Christopher Hegarthy in OpenJDK7:
>>>>> http://hg.openjdk.java.net/jdk7/tl/jdk/rev/58f325ba3e27
>>>>> (these changes are reviewed by Alan Bateman)
>>>>>
>>>>> Cheers
>>>>> Pavel Tisnovsky
>>>
>