Need reviewers for changes in java/net regression tests

[Dr Andrew John Hughes]

On 18:49 Thu 29 Jul     , Joe Darcy wrote:
> Chris Hegarty wrote:
> >
> >
> > On 07/26/10 14:00, Dr Andrew John Hughes wrote:
> >> .......
> >>
> >> I'm afraid I don't see the issue with bug IDs here.  Each OpenJDK7
> >> changeset already has an associated bug ID.  It should thus simply be
> >> a matter of backporting the relevant changesets and dropping any
> >> changes from them that should remain 7 only.
> >
> > Some of the test changes have been made when fixing a bug in the JDK7 
> > source... Oh, I noticed that the test in this area is not sufficient 
> > or has issues. Some tests have been fixed as part of a general cleanup 
> > to remove them from the ProblemList. We don't want to backport all the 
> > implementation source changes, only test changes that improve the 
> > quality of the tests. So there is no one to one mapping here. 
> 
> If there are fixes for correctness issues allowable under the Java SE 6 
> specification, I'd be open to the fixes being backported to OpenJDK 6.
> 
> Cheers,
> 
> -Joe

I still think that, even if only a subset of a changeset is backported, the
same bug ID should be used.  Creating huge changesets which don't have a clear
trace back to 7 makes things very hard to track.

I'm not sure that the bug-ID-per-changeset per method works well if
developers then pile lots of changes into a single changeset to avoid
having to create multiple bug IDs.  I've seen this on a number of
occasions (and also bundling multiple bug fixes into one changeset).
It makes backports to 6 much harder, because you then have a mix of
wanted and unwanted changes.  My preference would be for simple changesets
that fix one issue, where possible.

Thanks,
--
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8