[7u4-osx] Request for approval for 7123679: [macosx] Update regression tests that use os.name to work on MacOSX

Paul Hohensee paul.hohensee at oracle.com
Mon Jan 9 10:54:13 PST 2012


Approved.

Though there does seem to be a bit of confusion (to me, anyway)
between the places that check for solaris | linux | macos and the
places that check for !windows.  It would be good to define the
check in a single method and use that rather than scatter similar-to-
identical checks around the code.

Paul

On 1/9/12 1:29 PM, Kurchi Hazra wrote:
>
> Apologies for the wrong CR number in the subject. Corrected it here.
>
> Thanks,
> - Kurchi
>
>
> -------- Original Message --------
> Subject:     [7u4-osx] Request for approval for 7127199: [macosx] 
> Update regression tests that use os.name to work on MacOSX
> Date:     Mon, 09 Jan 2012 10:27:09 -0800
> From:     Kurchi Hazra <kurchi.subhra.hazra at oracle.com>
> Organization:     Oracle Corporation
> To:     jdk7u-dev at openjdk.java.net
> CC:     macosx-port-dev at openjdk.java.net
>
>
>
> This is a request to push the following fix to jdk7u-osx:
>
> CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7123679
>
> Webrev: http://cr.openjdk.java.net/~khazra/7123679/webrev.02/
>
> Reviewed by: alanb, swingler
>
> This changeset will be pushed on my behalf by Michael McMahon (michaelm).
>
> Thanks,
> Kurchi
>



More information about the jdk7u-dev mailing list