[7u4] Request for approval for CR 7088989 - Improve the performance for T4 by utilizing the newly provided crypto APIs

[Andrew Hughes]

----- Original Message -----
> On 3/15/12 4:29 PM, Andrew Hughes wrote:
> > I noticed you don't seem to have commented on how this breaks the
> > jdk7u guidelines.
> 
> Yeah, I wanted to leave that for a follow up e-mail, i.e. this one.
> The guidelines
> unfortunately get b0rken every now and then, in particular when new
> developers join
> the project, or straddle the thin red line between whatever deeds
> they need to do to
> get their changes through their internal systems, and the things they
> need to do to
> get their changes into this Project's forests.
> 
> My unofficial motto for this Project has been "E pur si muove". [0]
> 
> Sometimes, that means sending a private mail to the new developer to
> advise them on the
> fine print of this Project's guidelines. When Edvard and I drafted
> the guidelines,
> that meant putting in enough room to allow retroactive approvals for
> example, as I
> expected that someone will every now and then miss following the
> processes properly
> before they pushed a useful fix, and I wanted an opportunity to
> educate such developers
> on the fine print of the Project's processes without having to
> penalize them publicly
> first.
> 

Ok, but whether or not you raise this privately is not known to
external observers such as Omair and myself.

> All that said, when I see someone struggling with the processes, I
> try to educate them on it,
> just not necessarily publicly. For this particular change, when I
> looked at it before I
> retroactively approved it, I didn't see anything I'd find
> objectionable.

That doesn't imply others wouldn't.

> 
> I understand that you'd find it disappointing that the difference
> between Oracle JDK and
> the OpenJDK it's based on isn't always shrinking, but at the same
> time, I don't find it
> surprising, in light of what Oracle has said 2010 about continuing to
> offer its premium
> offerings, or disturbing, given that Oracle JDK != OpenJDK today. [1]

I didn't say it was either surprising or disturbing, just that it was
disappointing as it seemed to suggest a reversal in the trend of removing
such proprietary blobs.

My main issue is with the lack of review as, if we're going to have to
work with these islands of proprietary code, I'd like to be sure that
the OpenJDK build isn't affected by the addition of all these conditional
blocks to the makefiles and elsewhere.

> In this case, I
> found it nice to see more regression tests make their way into
> OpenJDK - and I appreciate your
> kind offer in this thread to generalize this new batch to make it
> work with other providers.
> Thank you very much for offering to do that.

I agree (as I believe I already said) that the tests are useful, and it's
surprising to me that such tests weren't already present.  It's just
a pity that weren't general from the start.

> 
> cheers,
> dalibor topic
> 
> [0] https://en.wikipedia.org/wiki/Eppur_si_muove
> [1] http://www.oracle.com/us/corporate/press/173782
> --
> Oracle <http://www.oracle.com>
> Dalibor Topic | Principal Product Manager
> Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961
> <tel:+491737185961>
> Oracle Java Platform Group
> 
> ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg
> 
> ORACLE Deutschland B.V. & Co. KG
> Hauptverwaltung: Riesstr. 25, D-80992 München
> Registergericht: Amtsgericht München, HRA 95603
> Geschäftsführer: Jürgen Kunz
> 
> Komplementärin: ORACLE Deutschland Verwaltung B.V.
> Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
> Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
> Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher
> 
> Green Oracle <http://www.oracle.com/commitment> Oracle is committed
> to developing practices and products that help protect the
> environment
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07