Review for 7155419

Kumar Srinivasan kumar.x.srinivasan at oracle.COM
Wed Mar 21 15:44:04 PDT 2012


It looks generally good, few comments, can be fixed for the
next release.

1.  Standardize the terms JVM and  HotSpot it seems to be used
       interchangeably, good idea to fix them correctly for the next 
release.

2. URLs ending with a "." may not work with some browsers depending on how
     they interpret it, this is however  the man page, therefore the 
terminal (xterm etc.)
     needs to pass this along to the browser. I don't know how many 
people use this
     versus accessing the man page directly on the web.

3. Usually we don't use the term "soft goal", a better choice would be 
"JVM hint".

4. These pages are localized for JA for Solaris, I suggest sending the 
L10N team
      a heads-up.

Kumar

> In the normal JDK workspaces, we try pretty hard to keep to the 80 
> space/line restriction.
>
>     http://www.oracle.com/technetwork/java/codeconv-138413.html
>
> This makes the code and especially framed webrev's *MUCH* easier to 
> read.  Having to slide frames back/forth is not very efficient.  I 
> would encourage your teams to adopt a similar strategy.
>
> For example:
>
> linux:  java.1  Line 475 is quite long.
>
> Being from the JDK libraries, the term "soft goal" isn't something we 
> typically use.  If hotspot developers are ok with, I guess I am.
>
> Brad
>
>
>
> On 3/21/2012 9:51 AM, Bhavesh Patel wrote:
>> Hi,
>> This is in connection with CR 7153977. The writer has updated the
>> JRockit reference from the man page in question. This is addressed as a
>> separate bug. I have generated the updated man page which could be
>> reviewed at http://cr.openjdk.java.net/~bpatel/7155419/webrev.00/
>>
>> Regards,
>> Bhavesh.




More information about the jdk7u-dev mailing list