[7u6] Code Review Request for 7146728 Inconsistent length for the generated secret using DH key agreement impl from SunJCE and PKCS11

[Brad Wetmore]

I've been wondering again if we should have actually thrown the 
exception in engineGenerateSecret() in DHKeyAgreement.java.  You're 
right, it should never happen, maybe a comment to that effect?

     // should never happen since code lengths in the two
     // methods are identical.

Looks good otherwise,

Brad





On 3/22/2012 6:15 PM, Valerie (Yu-Ching) Peng wrote:
> Hi, Brad,
>
> I plan to backport the fixes for
> 7146728: Inconsistent length for the generated secret using DH key
> agreement impl from SunJCE and PKCS11
> to jdk7u6.
>
> They are exactly the same as the jdk8 fixes.
> The webrev for 7u can be found here:
> http://cr.openjdk.java.net/~valeriep/7146728_7u/webrev.00/
>
> Thanks!
> Valerie
>