[7u-dev] Request for approval for 8049542: C2: assert(size_in_words <= (julong)max_jint) failed: no overflow

[Vladimir Kozlov]

Thank you, Seán

Vladimir

On 8/5/14 12:32 PM, Seán Coffey wrote:
> Approved.
>
> regards,
> Sean.
>
> On 05/08/2014 19:28, Vladimir Kozlov wrote:
>> Sorry about webrev. Here is correct one:
>>
>> http://cr.openjdk.java.net/~kvn/8049252_7u/webrev
>>
>> It fixes the problem we have with the version of gcc compiler on one
>> of our platforms. Sign-extension instruction is not generated and as
>> result the assert is triggered due to garbage in upper bits.
>> The added juint cast is valid because the length value is positive.
>>
>> Thanks,
>> Vladimir
>>
>> On 8/5/14 2:14 AM, Seán Coffey wrote:
>>> Vladimir,
>>>
>>> the bug report is not public. Can you give a brief overview of what's
>>> being fixed and/or point to review thread.
>>> Rule 9 : http://openjdk.java.net/projects/jdk7u/groundrules.html
>>>
>>> The webrev link doesn't work also.
>>>
>>> regards,
>>> Sean.
>>>
>>> On 05/08/2014 01:07, Vladimir Kozlov wrote:
>>>> Requesting push approval for JDK-8049542. It is only needed in 7u.
>>>> Changes were reviewed and tested.
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8049542
>>>> http://cr.openjdk.java.net/~kvn/webrevs/8049252_7u/webrev
>>>>
>>>> Thanks,
>>>> Vladimir
>>>
>