Review request: JDK-8012643 JDK8 b86 source with GPL header errors (jaxws & jdk)

[David Katleman]

On 4/22/2013 9:25 AM, Joe Darcy wrote:
> For large changes like this, I recommend running the lic_check.sh 
> script in the forest to verify the copyright headers are as expected.

I agree, lic_check.sh should be used in such situations.

Would have caught the problem prior to integration, though it would have 
taking  a couple iterations as it would have found just the copyright 
line error first

     Copyright (c) 1997-2013 Oracle and/or its affiliates. All rights 
reserved.

And then gone on to flag the header content issue in the second running.

Thanks
             Dave


> On 04/22/2013 01:55 AM, Miroslav Kos wrote:
>> Hi,
>> yes, this was a problem on our side - fixing it just now, those were 
>> newly added packages and I forget to add them to packages to be 
>> rebranded.
>>
>> Miran
>>
>>
>>
>> On 04/20/2013 09:18 AM, Alan Bateman wrote:
>>> On 20/04/2013 00:04, David Katleman wrote:
>>>> Below are corrections to GPL headers found in JDK8 b86:
>>>>
>>>> http://cr.openjdk.java.net/~katleman/8012643/webrev.jaxws.01
>>>> http://cr.openjdk.java.net/~katleman/8012643/webrev.jdk.01
>>>>
>>>> Corresponding CR
>>>>
>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8012643
>>>>
>>>> The jdk headers are punctuation changes.
>>>>
>>>> jaxws integrated 51 files with a wrong GPL header, so that part is 
>>>> a bit more involved.
>>>> Still no code changes, just headers, so anyone is qualified to 
>>>> review them.
>>> Looks fine to me too.
>>>
>>> I sponsored the JAX-WS update that went into b86. It was a monster 
>>> patch (>70000 lines of changes) and really hard to see the wood from 
>>> the trees when bringing in this volume of changes. In this case, the 
>>> 51 files had to have their package changed from upstream so I'll bet 
>>> this is why their headers were missed.
>>>
>>> Going forward, are fixing up issues in master a problem? Which 
>>> scripts should be run to catch issues like this? I see in the top 
>>> level repo that we have lic_check.sh - is that the script you use? 
>>> Do you want these issues caught by integrators before they are 
>>> pushed to master?
>>>
>>> -Alan.
>>
>