Porting changes between JDK 9 and JDK 8u

[Seán Coffey]

This seems like a good proposal to me Chris. I think a suitable update 
could be made to the public code review rules we currently have on the 
Project page :
http://openjdk.java.net/projects/jdk8u/codereview.html

I'm proposing we make this change to the code review rules :

Change Rule 1 from :
> If the content of a changeset submitted for review for a public JDK 8 
> Update forest is the same patch as the corresponding changeset 
> submitted or committed for JDK 9, then it does not have to be 
> resubmitted. In that case the URL for the changeset in the JDK 9 
> repository will suffice.

to

>> With modular source code changes in JDK 9, any patch being backported 
>> from the JDK 9 Project should have the unshuffle_patch.sh script [1] 
>> run against it. If the script runs successfully and if the resulting 
>> patch applies without error to the JDK 8 Update repository, then it 
>> does not have to be resubmitted for review. In that case the URL for 
>> the changeset in the JDK 9 repository will suffice. If any issues are 
>> encountered during the unshuffle_patch.sh script execution or during 
>> the patch import, a code review for the backport changes should be 
>> requested.
> [1] http://cr.openjdk.java.net/~chegar/docs/portingScript.html

Unless I hear otherwise, I'll update the code review rules to reflect 
this change on Friday (22nd)

Regards,
Sean.

On 18/08/2014 20:52, Chris Hegarty wrote:
> Hi 8u Maintainers,
>
> Now that the JEP 201: Modular Source Code [1] changes have been integrated into the JDK 9 mainline, porting changes between JDK 9 and JDK 8u will be a little more difficult. To help with this, a porting script [2] has been developed, and checked into the JDK 9 mainline, along with the source code re-organization.
>
> I would like to propose a small change to the process for requesting ports of JDK 9 changes into JDK 8u. It may be a simple change to the Push Approval Request Template [3], or the something more elaborate in the Ground Rules [4], I'm not exactly sure. Essentially, where you typically see a backport approval request with ‘the patch applied cleanly’, you may accept ‘the unshuffled patch applied cleanly’. Where the 'unshuffled patch' is a patch that has been run through the porting script [2].
>
> -Chris.
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8051619
> [2] http://cr.openjdk.java.net/~chegar/docs/portingScript.html
> [3] http://openjdk.java.net/projects/jdk8u/approval-template.html
> [4] http://openjdk.java.net/projects/jdk8u/groundrules.html