[8u40] Request for review and approval: 8059070 : [TESTBUG] java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java failed - timeout

Konstantin Shefov konstantin.shefov at oracle.com
Mon Dec 1 10:53:05 UTC 2014


Paul,

On 01.12.2014 11:48, Paul Sandoz wrote:
> On Nov 28, 2014, at 6:21 PM, Konstantin Shefov <konstantin.shefov at oracle.com> wrote:
>
>> Please review and approve backport of JDK-8059070 to 8u40.
>>
>> This is the test fix and it is a bit different from that of JDK 9.
>>
> Looks ok.
>
> Why is it different to the fix in 9?
It is because in JDK 8u there is no adjustTimeout function in Utils 
class, so I added it. And I think it will be better to define where to 
stop interations depending on the iteration with the maximum time, not 
the average iteration time.
If tests still fail with timeout in JDK 9, I will also change average 
time to maximum in JDK 9.

-Konstantin
>
> Paul.
>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8059070
>> Webrev: http://cr.openjdk.java.net/~kshefov/8059070_8u/webrev.00
>> Review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029831.html
>> Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/1d480d8fcf8c
>>
>>
>> Thanks,
>> -Konstantin



More information about the jdk8u-dev mailing list