[8u40] Request for review and approval: 8059070 : [TESTBUG] java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java failed - timeout

Paul Sandoz paul.sandoz at oracle.com
Mon Dec 1 10:55:08 UTC 2014


On Dec 1, 2014, at 11:53 AM, Konstantin Shefov <konstantin.shefov at oracle.com> wrote:

> Paul,
> 
> On 01.12.2014 11:48, Paul Sandoz wrote:
>> On Nov 28, 2014, at 6:21 PM, Konstantin Shefov <konstantin.shefov at oracle.com> wrote:
>> 
>>> Please review and approve backport of JDK-8059070 to 8u40.
>>> 
>>> This is the test fix and it is a bit different from that of JDK 9.
>>> 
>> Looks ok.
>> 
>> Why is it different to the fix in 9?
> It is because in JDK 8u there is no adjustTimeout function in Utils class, so I added it. And I think it will be better to define where to stop interations depending on the iteration with the maximum time, not the average iteration time.
> If tests still fail with timeout in JDK 9, I will also change average time to maximum in JDK 9.
> 

Ok.

I see Igor has factored out similar functionality in a separate patch under review in core-libs.

Paul.


More information about the jdk8u-dev mailing list