[8u20] RFR: 8042440: awt_Plugin.h no longer needed

Seán Coffey sean.coffey at oracle.com
Thu Jul 17 14:39:06 UTC 2014


David,

I see this one slipped by. It's still pending for jdk8u-dev ? Consider 
it approved.

regards,
Sean.

On 12/06/2014 16:48, David DeHaven wrote:
> Please review the backport of JDK-8042440. The changes are identical to the JDK9 changes except for exactly one line:
>
> $ diff -Narup ~/Desktop/8042440-{8u,9}
> @@ -143,7 +143,7 @@ diff --git a/src/solaris/native/sun/awt/
>   -
>   -
>   -#define REFLECT_VOID_FUNCTION(name, arglist, paramlist)                 \
> --typedef name##_type arglist;                                            \
> +-typedef void name##_type arglist;                                       \
>   -void name arglist                                                       \
>   -{                                                                       \
>   -    static name##_type *name##_ptr = NULL;                              \
>
> It seems someone added a void return type to the function being deleted, which resulted in the patch conflict, the end result is the same, all that code is deleted.
>
>
> JBS Issue:
> https://bugs.openjdk.java.net/browse/JDK-8042440
>
> JDK 9 review:
> http://mail.openjdk.java.net/pipermail/awt-dev/2014-May/007671.html
>
> Existing JDK9 patch:
> http://hg.openjdk.java.net/jdk9/client/jdk/rev/75206fa5a43e
>
> JDK 8u-dev webrev:
> http://cr.openjdk.java.net/~ddehaven/8042440/8u-bp/
>
> -DrD-
>



More information about the jdk8u-dev mailing list