[8u40] Request for approval: 8031373: Lint warnings in java.util.stream

[Seán Coffey]

It's tricky to know where to draw the line on such changes. So the code 
now becomes :
> mv.visitMethodInsn(Opcodes.INVOKESTATIC, MHI, "castReference", 
> CLL_SIG, false);  ?
To be safe and keep with process, can you get a peer reviewer to give a 
quick look at this and also approve on this mail thread ?

Approved subject to review.

thanks,
Sean.

On 10/09/14 11:07, Vladimir Ivanov wrote:
> Sean, thank!
>
> There's one conflict due to different order of 8031373 & 8033666 in 8u 
> and 9. It's a trivial merge [1] and I don't think it worth a review. 
> Do you agree?
>
> Best regards,
> Vladimir Ivanov
>
> [1] src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java
> @@ -437,7 +437,7 @@
>                  mv.visitLdcInsn(constantPlaceholder(pclass));
>                  mv.visitTypeInsn(Opcodes.CHECKCAST, CLS);
>                  mv.visitInsn(Opcodes.SWAP);
> -                mv.visitMethodInsn(Opcodes.INVOKESTATIC, MHI, "cast", 
> CLL_SIG);
> +                mv.visitMethodInsn(Opcodes.INVOKESTATIC, MHI, 
> "castReference", CLL_SIG);
>                  if (pclass.isArray())
>                      mv.visitTypeInsn(Opcodes.CHECKCAST, OBJARY);
>              }
>
> On 9/10/14, 1:51 PM, Seán Coffey wrote:
>> Please add a suitable noreg-* label to this bug report. I'm assuming
>> this change applies cleanly post the unshuffle script run. If not,
>> you'll need a review.
>>
>> Approved on the basis that this is a clean patch application.
>>
>> regards,
>> Sean.
>>
>> On 10/09/14 10:22, Vladimir Ivanov wrote:
>>> Hello,
>>>
>>> Please, approve integration of the following change into 8u40:
>>>   8031373: Lint warnings in java.util.stream
>>>   https://bugs.openjdk.java.net/browse/JDK-8031373
>>>   http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/2bb960ae3038
>>>
>>> I'd like to get it into 8u40 to minimize difference in JEP210
>>> implementation [1] between 8u & 9.
>>>
>>> Best regards,
>>> Vladimir Ivanov
>>>
>>> [1] https://bugs.openjdk.java.net/browse/JDK-8046703
>>