[8u40] Request for approval: 8031373: Lint warnings in java.util.stream

Paul Sandoz paul.sandoz at oracle.com
Wed Sep 10 11:22:42 UTC 2014


On Sep 10, 2014, at 12:07 PM, Vladimir Ivanov <vladimir.x.ivanov at oracle.com> wrote:

> Sean, thank!
> 
> There's one conflict due to different order of 8031373 & 8033666 in 8u and 9. It's a trivial merge [1] and I don't think it worth a review. Do you agree?
> 
> Best regards,
> Vladimir Ivanov
> 
> [1] src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java
> @@ -437,7 +437,7 @@
>                 mv.visitLdcInsn(constantPlaceholder(pclass));
>                 mv.visitTypeInsn(Opcodes.CHECKCAST, CLS);
>                 mv.visitInsn(Opcodes.SWAP);
> -                mv.visitMethodInsn(Opcodes.INVOKESTATIC, MHI, "cast", CLL_SIG);
> +                mv.visitMethodInsn(Opcodes.INVOKESTATIC, MHI, "castReference", CLL_SIG);
>                 if (pclass.isArray())
>                     mv.visitTypeInsn(Opcodes.CHECKCAST, OBJARY);
>             }
> 

+1

Paul.


More information about the jdk8u-dev mailing list