[8u-dev] Request for Approval: 8130910 hsperfdata file is created in wrong directory and not cleaned up if /tmp/hsperfdata_<username> has wrong permissions

[Daniel D. Daugherty]

Thanks! The changeset pushed about 15 minutes ago...

Dan


On 11/17/15 12:05 PM, Gerald Thornbrugh wrote:
> Hi Dan,
>> So here's what the commit looks like:
>>
>> $ hg log -v -r tip
>> changeset:   7667:9f8038f83a6e
>> tag:         tip
>> user:        clanger
>> date:        Tue Nov 17 09:39:45 2015 -0800
>> files:       src/os/aix/vm/perfMemory_aix.cpp 
>> src/os/bsd/vm/perfMemory_bsd.cpp src/os/linux/vm/perfMemory_linux.cpp 
>> src/os/solaris/vm/perfMemory_solaris.cpp
>> description:
>> 8130910: hsperfdata file is created in wrong directory and not 
>> cleaned up if /tmp/hsperfdata_<username> has wrong permissions
>> Summary: Add check for fchir() failure and disable shared PerfMemory 
>> in that case.
>> Reviewed-by: dcubed, simonis, gthornbr
>>
>>
>> I've compared this fix with the version that I sponsored for
>> JDK9-hs-rt back in August and it looks good.
>>
>> Christoph and Jerry, are you guys good with this changeset?
> I good with this change set.
>
> Thanks!
>
> Jerry
>>
>> Dan
>>
>> On 11/17/15 9:51 AM, Langer, Christoph wrote:
>>> Thanks in advance, Dan.
>>>
>>> -----Original Message-----
>>> From: Daniel D. Daugherty [mailto:daniel.daugherty at oracle.com]
>>> Sent: Dienstag, 17. November 2015 17:50
>>> To: Langer, Christoph <christoph.langer at sap.com>; Rob McKenna 
>>> <rob.mckenna at oracle.com>; jdk8u-dev at openjdk.java.net
>>> Cc: Gerald Thornbrugh <gerald.thornbrugh at oracle.com>
>>> Subject: Re: [8u-dev] Request for Approval: 8130910 hsperfdata file 
>>> is created in wrong directory and not cleaned up if 
>>> /tmp/hsperfdata_<username> has wrong permissions
>>>
>>> I'll take a look at sponsoring this in a little while.
>>>
>>> Dan
>>>
>>>
>>> On 11/17/15 9:44 AM, Langer, Christoph wrote:
>>>> OK, I added the label noreg-hard.
>>>>
>>>> Dan, Jerry, can anyone of you push the change?
>>>>
>>>> Thanks
>>>> Christoph
>>>>
>>>> -----Original Message-----
>>>> From: Rob McKenna [mailto:rob.mckenna at oracle.com]
>>>> Sent: Montag, 16. November 2015 17:05
>>>> To: Langer, Christoph <christoph.langer at sap.com>; 
>>>> jdk8u-dev at openjdk.java.net
>>>> Cc: Gerald Thornbrugh <gerald.thornbrugh at oracle.com>
>>>> Subject: Re: [8u-dev] Request for Approval: 8130910 hsperfdata file 
>>>> is created in wrong directory and not cleaned up if 
>>>> /tmp/hsperfdata_<username> has wrong permissions
>>>>
>>>> Approved. Please add an appropriate noreg label to the bug however.
>>>>
>>>>     -Rob
>>>>
>>>> On 16/11/15 15:56, Langer, Christoph wrote:
>>>>> Hi,
>>>>>
>>>>> can you please approve a direct backport of 8130910 to 8u-dev?
>>>>>
>>>>> Bug:
>>>>> https://bugs.openjdk.java.net/browse/JDK-8130910
>>>>>
>>>>> Review thread of JDK9:
>>>>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-August/019588.html 
>>>>>
>>>>>
>>>>> JDK9 changeset:
>>>>> http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/efc17f03e5d4
>>>>>
>>>>> I did a new webrev because the patch had a small reject in 
>>>>> perfMemory_aix.cpp:
>>>>> http://cr.openjdk.java.net/~clanger/webrevs/8130910.8udev/
>>>>>
>>>>> Thanks,
>>>>> Christoph
>>>>>
>>>
>>
>
>