[8u-dev] Request for approval for CR 8179079: Incremental HotSpot builds broken on Windows

[David Buck]

approved

Cheers,
-Buck

On 2018/04/19 0:30, Kevin Walls wrote:
> 
> Hi,
> 
> I'd like to request approval to backport from jdk10 to 8u:
> 
> 8179079: Incremental HotSpot builds broken on Windows
> JBS: https://bugs.openjdk.java.net/browse/JDK-8179079
> 
> 10 changeset:
> http://hg.openjdk.java.net/jdk10/jdk10/rev/6426c94ee05f
> 
> Original review thread: 
> http://mail.openjdk.java.net/pipermail/build-dev/2017-April/019046.html
> 
> It's not quite a clean backport, the same code is present but the sed 
> pattern is in a variable in later JDKs.
> Proposed 8u change: pasted below.
> 
> Thanks
> Kevin
> 
> 
> 
> diff -r 7a73b8b4ac8a -r 310b1d9c5772 make/common/NativeCompilation.gmk
> --- a/make/common/NativeCompilation.gmk Mon Apr 16 00:48:00 2018 -0700
> +++ b/make/common/NativeCompilation.gmk Wed Apr 18 03:57:40 2018 -0700
> @@ -116,6 +116,7 @@
>            ($(ECHO) $$@: \\ \
>            && $(SED) -e '/^Note: including file:/!d' \
>                -e 's|Note: including file: *||' \
> +          -e 's|\r||g' \
>                -e 's|\\|/|g' \
>                -e 's|^\([a-zA-Z]\):|/cygdrive/\1|g' \
>                -e '/$(subst /,\/,$(TOPDIR))/!d' \
>