[jdk8u-dev] Request for approval and review: 8209129: Further improvements to cipher buffer management

[dalibor topic]

Thanks, Max - Approved for jdk8u-dev.

cheers,
dalibor topic

On 24.08.2018 03:15, Weijun Wang wrote:
> I see. The change looks fine.
> 
> Thanks
> Max
> 
>> On Aug 24, 2018, at 12:07 AM, Seán Coffey <sean.coffey at oracle.com> wrote:
>>
>> Yes - around that area. For 8u, there is no finalizer but a new finally block was added to 12. I've added the same to 8u.
>>
>>
>>>   111         try {
>>>   112             this.prf = Mac.getInstance(prfAlgo, SunJCE.getInstance());
>>>   113             this.key = deriveKey(prf, passwdBytes, salt, iterCount, keyLength);
>>>   114         } catch (NoSuchAlgorithmException nsae) {
>>>   115             // not gonna happen; re-throw just in case
>>>   116             InvalidKeySpecException ike = new InvalidKeySpecException();
>>>   117             ike.initCause(nsae);
>>>   118             throw ike;
>>>   119         } finally {
>>>   120             Arrays.fill(passwdBytes, (byte)0x00);
>>>   121         }
>>>
>> regards,
>> Sean.
>>
>>
>>
>> On 23/08/2018 17:01, Weijun Wang wrote:
>>> You mean the CleanerFactory difference?
>>>
>>>
>>>> On Aug 23, 2018, at 11:45 PM, Seán Coffey <sean.coffey at oracle.com>
>>>>   wrote:
>>>>
>>>> I found an issue with patch application to src/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java
>>>>
>>>> Corrected on line 120 now.
>>>>
>>>> new webev :
>>>> http://cr.openjdk.java.net/~coffeys/webrev.8209129.8u.v2/webrev/index.html
>>>>
>>>>
>>>> regards,
>>>> Sean.
>>>>
>>>>
>>>> On 23/08/2018 12:22, Seán Coffey wrote:
>>>>
>>>>> I'm looking to port this fix to jdk8u-dev. Fix already pushed to JDK 12. The patch applied almost cleanly. There was some minor failure concerning the insertion of import statements at top of files IIRC.
>>>>>
>>>>> JBS report :
>>>>> https://bugs.openjdk.java.net/browse/JDK-8209129
>>>>>
>>>>> review thread :
>>>>> http://mail.openjdk.java.net/pipermail/security-dev/2018-August/017838.html
>>>>> http://cr.openjdk.java.net/~coffeys/webrev.8209129.8u/webrev/
>>>>>
>>>>>
>>>>> regards,
>>>>> Sean.
>>>>>
>>>>>
>>
> 

-- 
<http://www.oracle.com> Dalibor Topic | Principal Product Manager
Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961
<tel:+491737185961>

ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher

<http://www.oracle.com/commitment> Oracle is committed to developing
practices and products that help protect the environment