[8u] [RFR] Request for Review of Backport of JDK-8078628: linux-zero does not build without precompiled header
David Holmes
david.holmes at oracle.com
Fri Feb 23 00:40:56 UTC 2018
Hi Andrew,
The imported copyright year changes need to be updated to reflect
current year.
The ifdef cleanups seem fine.
The actual include changes also seem fine.
I assume non-zero builds havfe also been tested?
Thanks,
David
On 22/02/2018 2:01 PM, Andrew Hughes wrote:
> [CCing hotspot list for review]
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8078628
> Webrev: http://cr.openjdk.java.net/~andrew/openjdk8/8078628/webrev.01/
> Review thread: http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-April/018239.html
>
> When testing a slowdebug build of Zero for the backport of 8194739, my build
> failed because I don't have pre-compiled headers enabled. It seems this
> was fixed in OpenJDK 9, but never backported.
>
> The backported version is pretty similar with a few adjustments for context
> in the older OpenJDK 8 version. The src/cpu/zero/vm/methodHandles_zero.hpp
> are my own addition from the same fix I came up with independently, and stops
> multiple inclusions of that header.
>
> Please review and approve for OpenJDK 8 so Zero builds without
> precompiled headers
> work there.
>
> Thanks,
>
More information about the jdk8u-dev
mailing list