[8u] [RFR] Request for Review of Backport of JDK-8078628: linux-zero does not build without precompiled header

[Andrew Hughes]

On 23 February 2018 at 00:40, David Holmes <david.holmes at oracle.com> wrote:
> Hi Andrew,
>
> The imported copyright year changes need to be updated to reflect current
> year.
>

The changes were actually my own rather than being part of the import, and
2015 is used because that's when the original patch was written. I assume
in 9 the current year was already in use. In backporting patches, I've
always kept
the copyright dates used in the patch as I don't believe that moving a
patch from
one tree to another warrants new copyright. Is there a policy on handling this?

> The ifdef cleanups seem fine.
>
> The actual include changes also seem fine.
>
> I assume non-zero builds havfe also been tested?
>

Yes, they're fine. I should mention that the patch has been in IcedTea
for at least
a year, so it's had a far bit of testing already on different builds.

> Thanks,
> David
>

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Web Site: http://fuseyism.com
Twitter: https://twitter.com/gnu_andrew_java
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222