[8u] [RFR] Request for Review of Backport of JDK-8078628: linux-zero does not build without precompiled header

[David Holmes]

On 23/02/2018 3:51 PM, Andrew Hughes wrote:
> On 23 February 2018 at 00:40, David Holmes <david.holmes at oracle.com> wrote:
>> Hi Andrew,
>>
>> The imported copyright year changes need to be updated to reflect current
>> year.
>>
> 
> The changes were actually my own rather than being part of the import, and
> 2015 is used because that's when the original patch was written. I assume
> in 9 the current year was already in use. In backporting patches, I've
> always kept
> the copyright dates used in the patch as I don't believe that moving a
> patch from
> one tree to another warrants new copyright. Is there a policy on handling this?

Our internal policy is that any change to a file requires we update the 
copyright year.

If you refactor code you move it from one file to another but that still 
requires a copyright update.

Cheers,
David

>> The ifdef cleanups seem fine.
>>
>> The actual include changes also seem fine.
>>
>> I assume non-zero builds havfe also been tested?
>>
> 
> Yes, they're fine. I should mention that the patch has been in IcedTea
> for at least
> a year, so it's had a far bit of testing already on different builds.
> 
>> Thanks,
>> David
>>
> 
> Thanks,
>