[8u] [RFR] Request for Review of Backport of JDK-8078628: linux-zero does not build without precompiled header

[Andrew Hughes]

On 26 February 2018 at 06:14, David Holmes <david.holmes at oracle.com> wrote:
> On 26/02/2018 4:01 PM, Andrew Hughes wrote:
>>
>> On 23 February 2018 at 06:17, David Holmes <david.holmes at oracle.com>
>> wrote:
>>
>> ...
>>
>>>
>>> Our internal policy is that any change to a file requires we update the
>>> copyright year.
>>>
>>> If you refactor code you move it from one file to another but that still
>>> requires a copyright update.
>>>
>>> Cheers,
>>> David
>>>
>>>
>>
>> And it has been updated; to the year the changes were made.
>
>
> That's not the rule we (Oracle) have.
>
>> To change it to the current year would be a lie as that's not when
>> these changes were made or published.
>
>
> It's when they were made/published in _this_ file and the copyright is
> applied to the file.
>
> Always frustrating that what should be a simple set of rules easily
> expressed and clearly written down, never are because they are the domain of
> the lawyers. :(
>
> David

I guess it was a mistake to apply logic to legal reasoning. It seldom
works out happily.

Here's a revised version with the current year used. thread.hpp already has
the current year, thanks to 8189170. I also dropped the guard changes in
src/cpu/zero/vm/methodHandles_zero.hpp as it makes more sense to do
that under a separate bug and patch, which includes the newer versions too.

http://cr.openjdk.java.net/~andrew/openjdk8/8078628/webrev.02

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Web Site: http://fuseyism.com
Twitter: https://twitter.com/gnu_andrew_java
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222