[8u] [RFR] Request for Review of Backport of JDK-8078628: linux-zero does not build without precompiled header

[David Holmes]

Thanks Andrew! Reviewed.

David

On 27/02/2018 4:58 AM, Andrew Hughes wrote:
> On 26 February 2018 at 06:14, David Holmes <david.holmes at oracle.com> wrote:
>> On 26/02/2018 4:01 PM, Andrew Hughes wrote:
>>>
>>> On 23 February 2018 at 06:17, David Holmes <david.holmes at oracle.com>
>>> wrote:
>>>
>>> ...
>>>
>>>>
>>>> Our internal policy is that any change to a file requires we update the
>>>> copyright year.
>>>>
>>>> If you refactor code you move it from one file to another but that still
>>>> requires a copyright update.
>>>>
>>>> Cheers,
>>>> David
>>>>
>>>>
>>>
>>> And it has been updated; to the year the changes were made.
>>
>>
>> That's not the rule we (Oracle) have.
>>
>>> To change it to the current year would be a lie as that's not when
>>> these changes were made or published.
>>
>>
>> It's when they were made/published in _this_ file and the copyright is
>> applied to the file.
>>
>> Always frustrating that what should be a simple set of rules easily
>> expressed and clearly written down, never are because they are the domain of
>> the lawyers. :(
>>
>> David
> 
> I guess it was a mistake to apply logic to legal reasoning. It seldom
> works out happily.
> 
> Here's a revised version with the current year used. thread.hpp already has
> the current year, thanks to 8189170. I also dropped the guard changes in
> src/cpu/zero/vm/methodHandles_zero.hpp as it makes more sense to do
> that under a separate bug and patch, which includes the newer versions too.
> 
> http://cr.openjdk.java.net/~andrew/openjdk8/8078628/webrev.02
> 
> Thanks,
>