[8u] Request for Approval : Backport of 8171049 : Era.getDisplayName doesn't work with non-IsoChronology

[David Buck]

approved

Cheers,
-Buck

> On Nov 9, 2018, at 17:41, Deepak Kejriwal <deepak.kejriwal at oracle.com> wrote:
> 
> Hi David,
> 
> Sorry, I specified change wrong change set url for master bug. Correcting the change set url for master bug.
> 
> Please approve the backport of JDK-8171049 to 8u-dev.
> 
> Master bug :  https://bugs.openjdk.java.net/browse/JDK-8171049
> Webrev for [8u-dev]:  http://cr.openjdk.java.net/~rpatil/8171049/webrev.00/
> JDK Review Thread: http://mail.openjdk.java.net/pipermail/i18n-dev/2018-November/002682.html
> 
> 
> Master Bug Change set: http://hg.openjdk.java.net/jdk10/jdk10/jdk/rev/965d4dde0086
> Master Review Thread : http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-August/049037.html
> 
> Summary:
> 
> The fix was clean backport but new test file "TestEraDisplayName.java" added as part of fix is modified as per jdk 8 release:-  
> 	. All test written in jdk 10 are written to verify the CLDR resource. Since, in case of jdk 8 "CLDR" is not default locale providers, added Djava.locale.providers=CLDR as JVM parameter to test. 
> 	. Some resource keys in jdk 8 does not exist in both CLDR and JRE due to which Era.getDisplayName() returns numeric value. Modified such test cases accordingly
> 
> All the related testing is done and is a pass.
> 
> Regards,
> Deepak
> 
> 
> -----Original Message-----
> From: David Buck 
> Sent: Friday, November 9, 2018 1:56 PM
> To: Deepak Kejriwal <deepak.kejriwal at oracle.com>
> Cc: jdk8u-dev at openjdk.java.net
> Subject: Re: [8u] Request for Approval : Backport of 8171049 : Era.getDisplayName doesn't work with non-IsoChronology
> 
> HI Deepak,
> 
> This looks like a different fix:
> 
>> Master Bug Change set: http://hg.openjdk.java.net/jdk/jdk/rev/8dfed4387312
> 
> Cheers,
> -Buck
> 
>> On Nov 9, 2018, at 13:55, Deepak Kejriwal <deepak.kejriwal at oracle.com> wrote:
>> 
>> Hi,
>> 
>> 
>> 
>> Please approve the backport of JDK-8171049 to 8u-dev.
>> 
>> 
>> 
>> Master bug :  https://bugs.openjdk.java.net/browse/JDK-8171049
>> 
>> Webrev for [8u-dev]:  http://cr.openjdk.java.net/~rpatil/8171049/webrev.00/
>> 
>> JDK Review Thread: http://mail.openjdk.java.net/pipermail/i18n-dev/2018-November/002682.html
>> 
>> 
>> 
>> 
>> 
>> Master Bug Change set: http://hg.openjdk.java.net/jdk/jdk/rev/8dfed4387312
>> 
>> Master Review Thread : http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-August/049037.html
>> 
>> 
>> 
>> Summary:
>> 
>> 
>> 
>> The fix was clean backport but new test file "TestEraDisplayName.java" added as part of fix is modified as per jdk 8 release:-  
>> 
>> .         All test written in jdk 10 are written to verify the CLDR resource. Since, in case of jdk 8 "CLDR" is not default locale providers, added Djava.locale.providers=CLDR as JVM parameter to test. 
>> 
>> .         Some resource keys in jdk 8 does not exist in both CLDR and JRE due to which Era.getDisplayName() returns numeric value. Modified such test cases accordingly
>> 
>> 
>> 
>> All the related testing is done and is a pass.
>> 
>> 
>> 
>> Regards,
>> 
>> Deepak
>> 
>> 
>