RFR[8u backport] 8213992: Rename and make DieOnSafepointTimeout the diagnostic option

Hohensee, Paul hohensee at amazon.com
Mon Nov 26 18:09:22 UTC 2018


Lgtm too, and +1 on backporting to 11u as well. I'm a bit surprised that the original RFE doesn't have a CSR, since it changed an interface. But, since there was no CSR for the original RFE, imo there's no need for one for backports.

Paul

On 11/26/18, 9:39 AM, "jdk8u-dev on behalf of Zhengyu Gu" <jdk8u-dev-bounces at openjdk.java.net on behalf of zgu at redhat.com> wrote:

    Thanks, Aleksey!
    
    -Zhengyu
    
    On 11/25/18 1:29 PM, Aleksey Shipilev wrote:
    > Not the 8u Reviewer, but backport webrev looks fine to me.
    > 
    > Thanks,
    > -Aleksey
    > 
    > On 11/25/18 7:02 PM, Zhengyu Gu wrote:
    >> Hi Aleksey,
    >>
    >> Can I take this as reviewed?
    >>
    >> Thanks,
    >>
    >> -Zhengyu
    >>
    >> On 11/23/18 8:19 AM, Aleksey Shipilev wrote:
    >>> Needs to be backported to jdk11 too?
    >>>
    >>> -Aleksey
    >>>
    >>> On 11/23/18 1:45 PM, Zhengyu Gu wrote:
    >>>> Hi,
    >>>>
    >>>> I would like to backport this RFE, it helps to debug long safepoint sync time.
    >>>>
    >>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8213992
    >>>> Original review: http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-November/035255.html
    >>>>
    >>>> Backport has only minor conflicts.
    >>>> Backport Webrev: http://cr.openjdk.java.net/~zgu/8213992-8u/webrev.00/
    >>>>
    >>>>
    >>>> Thanks,
    >>>>
    >>>> -Zhengyu
    >>>
    >>>
    > 
    > 
    



More information about the jdk8u-dev mailing list