RFR[8u backport] 8213992: Rename and make DieOnSafepointTimeout the diagnostic option

[David Holmes]

On 27/11/2018 4:09 am, Hohensee, Paul wrote:
> Lgtm too, and +1 on backporting to 11u as well. I'm a bit surprised that the original RFE doesn't have a CSR, since it changed an interface. But, since there was no CSR for the original RFE, imo there's no need for one for backports.

"Interfaces that are experimental or for diagnostic purposes do not need 
to go through CSR process, but the CSR process may be employed if 
feedback from the CSR reviewers is desired." [1]

And it was originally a develop flag which is also outside the CSR 
process (though not mentioned in the CSR FAQ).

Cheers,
David

[1] https://wiki.openjdk.java.net/display/csr/CSR+FAQs



> Paul
> 
> On 11/26/18, 9:39 AM, "jdk8u-dev on behalf of Zhengyu Gu" <jdk8u-dev-bounces at openjdk.java.net on behalf of zgu at redhat.com> wrote:
> 
>      Thanks, Aleksey!
>      
>      -Zhengyu
>      
>      On 11/25/18 1:29 PM, Aleksey Shipilev wrote:
>      > Not the 8u Reviewer, but backport webrev looks fine to me.
>      >
>      > Thanks,
>      > -Aleksey
>      >
>      > On 11/25/18 7:02 PM, Zhengyu Gu wrote:
>      >> Hi Aleksey,
>      >>
>      >> Can I take this as reviewed?
>      >>
>      >> Thanks,
>      >>
>      >> -Zhengyu
>      >>
>      >> On 11/23/18 8:19 AM, Aleksey Shipilev wrote:
>      >>> Needs to be backported to jdk11 too?
>      >>>
>      >>> -Aleksey
>      >>>
>      >>> On 11/23/18 1:45 PM, Zhengyu Gu wrote:
>      >>>> Hi,
>      >>>>
>      >>>> I would like to backport this RFE, it helps to debug long safepoint sync time.
>      >>>>
>      >>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8213992
>      >>>> Original review: http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-November/035255.html
>      >>>>
>      >>>> Backport has only minor conflicts.
>      >>>> Backport Webrev: http://cr.openjdk.java.net/~zgu/8213992-8u/webrev.00/
>      >>>>
>      >>>>
>      >>>> Thanks,
>      >>>>
>      >>>> -Zhengyu
>      >>>
>      >>>
>      >
>      >
>      
>