[8u] Request for enhancement backport approval for 8059038: Create new launcher for SA tools

Kevin Walls kevin.walls at oracle.com
Wed Nov 28 12:18:53 UTC 2018


Hi Severin,

I would be in favour of things that make the SA tools more visible. 8-)

Did you mean to create a clhsdb launcher as well as the jhsdb one I can 
see here?

The alternative would be backporting the jhsdb command itself, but we 
don't want to take _out_ any existing launchers, and having both would 
be odd, so I'd vote for what you're proposing here.

Thanks
Kevin


On 20/11/2018 17:29, Severin Gehwolf wrote:
> Hi,
>
> Please approve this enhancement backport request which adds launchers
> for CLHSDB and HSDB (part of the sa-jdi.jar) currently not present in
> JDK 8u. JDK 9+ has 'jshsdb clhsdb' (CLI) and 'jhsdb hsdb' (GUI) for the
> serviceability agent. This patch would make those available in JDK 8u
> too.
>
> The risk of making them available is none. It's not possible to use
> them this way right now. The commands don't exist. Except for a new
> launcher no new code has been added. The launcher delegates to existing
> CLHSDB and HSDB classes.
>
> Testing: New basic test, manual testing that launchers work.
>
> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8059038/01/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8059038
>
> Thoughts?
>
> Thanks,
> Severin
>



More information about the jdk8u-dev mailing list