[8u] Request for enhancement backport approval for 8059038: Create new launcher for SA tools

[Severin Gehwolf]

Hi Kevin,

On Wed, 2018-11-28 at 12:18 +0000, Kevin Walls wrote:
> Hi Severin,
> 
> I would be in favour of things that make the SA tools more visible. 8-)
> 
> Did you mean to create a clhsdb launcher as well as the jhsdb one I can 
> see here?

Not sure what you mean by this.

In JDK 9+ clhsdb is being launched with jhsdb, is it not? In particular
this: "bin/jhsdb clhsdb". The gui would be "bin/jhsdb hsdb". After this
patch JDK 8 will have jhsdb which will be able to launch 'hsdb' or
'clhsdb' in the same way as JDK 9+ does (modulo different switches like
--pid, etc.)

> The alternative would be backporting the jhsdb command itself, but we 
> don't want to take _out_ any existing launchers, and having both would 
> be odd, so I'd vote for what you're proposing here.

Maybe I'm wrong, but the proposed patch adds the jhsdb command into bin
for JDK 8. Thanks for your input!

Cheers,
Severin

> Thanks
> Kevin
> 
> 
> On 20/11/2018 17:29, Severin Gehwolf wrote:
> > Hi,
> > 
> > Please approve this enhancement backport request which adds launchers
> > for CLHSDB and HSDB (part of the sa-jdi.jar) currently not present in
> > JDK 8u. JDK 9+ has 'jshsdb clhsdb' (CLI) and 'jhsdb hsdb' (GUI) for the
> > serviceability agent. This patch would make those available in JDK 8u
> > too.
> > 
> > The risk of making them available is none. It's not possible to use
> > them this way right now. The commands don't exist. Except for a new
> > launcher no new code has been added. The launcher delegates to existing
> > CLHSDB and HSDB classes.
> > 
> > Testing: New basic test, manual testing that launchers work.
> > 
> > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8059038/01/
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8059038
> > 
> > Thoughts?
> > 
> > Thanks,
> > Severin
> > 
> 
>