RFA: 8044235: src.zip should include all sources

[Seán Coffey]

Severin,

this is an enhancement and as such should be accompanied by an 
enhancement backport approval template :

http://openjdk.java.net/projects/jdk8u/enhancement-template.html

I've long been a fan of bringing this back to jdk8u-dev also. This one 
is currently in review. In the interim, please log an enhancement 
request so that we can track such requests.

regards,
Sean.


On 26/09/2018 17:43, Severin Gehwolf wrote:
> Hi,
>
> Please approve this backport request for 8044235 so as to include all
> sources in src.zip produced by the build. It will only include all
> sources when OPENJDK is defined. So it should be OK for Oracle JDK
> builds.
>
> I should mention that this increases the size of src.zip from about
> 25MB to 50MB. With that being said, src.zip is supposed to help Java
> developers stepping through their code. Randomly omitting sources for
> some classes while including others does not make a lot of sense.
> OpenJDK is *open source* after all. We are in 2018 (do those extra 25MB
> really matter?). Downstream consumers can remove src.zip from their
> bundle if they're concerned about size. In Fedora, we have been using
> this patch for years. There, src.zip is in a separate package so not
> everybody gets it by default. Problem solved :)
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8044235
>
> Patch is the same as for JDK 9:
> http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/5cab03c4e5f9
>
> Original review thread is here:
> http://mail.openjdk.java.net/pipermail/jdk9-dev/2014-May/000785.html
>
> Thanks,
> Severin
>