[8u] Request for enhancement backport approval for 8044235: src.zip should include all sources

[Severin Gehwolf]

Hi,

Please approve this enhancement backport so as to include all sources
in src.zip as produced by an *OpenJDK* build. Currently only a select
set of sources are part of src.zip. Given that OpenJDK is open source
anyway, it makes developers lives easier if *all* source classes are
included in src.zip when stepping through Java code.

Bug: https://bugs.openjdk.java.net/browse/JDK-8044235
Patch: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/5cab03c4e5f9

The risks are minimal as the change only affects developers using
src.zip in the first place. What's more, the change is guarded by
"ifdef OpenJDK", hence shouldn't affect non-OpenJDK builds.

I should note that src.zip increases in size from ~25MB to ~50MB. Given
that any Java developer benefits from having sources readily available
for debugging, I think this is a reasonable trade-off in 2018: "Better
developer experience" >>> "increased size of src.zip" 

Testing: Upstream OpenJDK 8 build. Verified manually[1] that sources
for classes such as DESCrypt are in src.zip (which weren't before).

Thanks,
Severin

[1] unzip -l <j2sdk-image>/src.zip | grep <class>