[8u-jfr] RFR (S) 8203287: Zero fails to build after JDK-8199712 (Flight Recorder)

[Aleksey Shipilev]

On 8/16/19 1:51 PM, Mario Torre wrote:
> Hi Aleksey,
> 
> Patch looks good, I have only one question to what happens if someone
> does indeed call this:
> 
> +  bool pd_get_top_frame_for_profiling(frame* fr_addr,
> +                                      void* ucontext,
> +                                      bool isInJava) {
> +    ShouldNotCallThis();
> +    return false; // silence compile warning
> +  }
> +

VM would abort with hs_err saying so. I believe JFR would be disabled at build-time when building
Zero, so this should be unreachable at runtime. I believe that hunk was to plug the build/linkage
failure.

-Aleksey