[8u-jfr] RFR (S) 8203287: Zero fails to build after JDK-8199712 (Flight Recorder)

[Severin Gehwolf]

Hi Mario,

On Fri, 2019-08-16 at 13:51 +0200, Mario Torre wrote:
> Hi Aleksey,
> 
> Patch looks good, I have only one question to what happens if someone
> does indeed call this:
> 
> +  bool pd_get_top_frame_for_profiling(frame* fr_addr,
> +                                      void* ucontext,
> +                                      bool isInJava) {
> +    ShouldNotCallThis();
> +    return false; // silence compile warning
> +  }
> +
> 
> This is done by src/share/vm/jfr/periodic/sampling/jfrCallTrace.cpp as
> far as I can see.

Then somebody is trying to do JFR profiling on a Zero JVM which isn't
supported. The patch proposed is just enough to get Zero building again
with the JFR port so it seems reasonable.

Thanks,
Severin

> You have commit right afaik, the repository is open to anyone who has
> privileges for 8u-dev.
> 
> Cheers,
> Mario
> 
> On Fri, Aug 16, 2019 at 11:14 AM Aleksey Shipilev <shade at redhat.com> wrote:
> > Missing backport:
> >   https://bugs.openjdk.java.net/browse/JDK-8203287
> > 
> > Zero fails to build, because files are missing and some defines are wrong. Most of that is fixed in
> > the original backport, so I just needed to adapt it for jfr-8u-incubator. vm_version_ext_zero
> > required dropping cpu_description support -- it is not available in 8u. Changes in jfrTime.cpp are
> > already present in 8u backport.
> > 
> > Webrev for jdk8u-jfr-incubator/hotspot:
> >   https://cr.openjdk.java.net/~shade/8203287/webrev.8u-jfr.01/
> > 
> > I don't think I have push privileges for that repository, so would appreciate sponsorship.
> > 
> > Testing: x86_64 zero build
> > 
> > --
> > Thanks,
> > -Aleksey
> > 
> 
>