[8u-jfr] RFR (S) 8203287: Zero fails to build after JDK-8199712 (Flight Recorder)

[Mario Torre]

On Fri, Aug 16, 2019 at 2:45 PM Severin Gehwolf <sgehwolf at redhat.com> wrote:
>
> Hi Mario,
>
> On Fri, 2019-08-16 at 13:51 +0200, Mario Torre wrote:
> > Hi Aleksey,
> >
> > Patch looks good, I have only one question to what happens if someone
> > does indeed call this:
> >
> > +  bool pd_get_top_frame_for_profiling(frame* fr_addr,
> > +                                      void* ucontext,
> > +                                      bool isInJava) {
> > +    ShouldNotCallThis();
> > +    return false; // silence compile warning
> > +  }
> > +
> >
> > This is done by src/share/vm/jfr/periodic/sampling/jfrCallTrace.cpp as
> > far as I can see.
>
> Then somebody is trying to do JFR profiling on a Zero JVM which isn't
> supported. The patch proposed is just enough to get Zero building again
> with the JFR port so it seems reasonable.

Yeah, I guess that trying to profile with zero would be a stretch.
Maybe we should have a patch that disables the option to run with JFR
in the first place. Nonetheless this would be a separate call, the
patch is good to go.

Cheers,
Mario
-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898