[8u] RFA 8204142: AWT hang occurs when sequenced events arrive out of sequence in multiple AppContexts

Andrew Hughes gnu.andrew at redhat.com
Mon Feb 25 16:59:04 UTC 2019


On Mon, 25 Feb 2019 at 16:47, Langer, Christoph
<christoph.langer at sap.com> wrote:
>
> Hi,
>
> > I volunteer to rewrite Fix Versions myself, if it comes to that :)
> > >
> > > -Aleksey
> > >
> >
> > Ok, thanks for volunteering :P
> > --
> And I had already volunteered on Friday [0]
>

Ah, thanks :) Sorry, still catching up on e-mails.

> But, @Paul, there are 2 things I noticed with the latest pushes:
> a) your pushes, like [1] have exchanged the original author of the fix with your name. Usually, for downports, unless you don't completely rewrite the original change, the author should be kept the original author. Probably it's a bit more difficult to get this fixed with all the reshuffling that has to be done for 8u patches. But I think we should stick to that procedure. Or what do other folks say here?

I agree. That's the way I've always done backports in 6 & 7.
It's a simple matter of hg commit -u <USER>.

> And there is
> b) You introduced merge patches like [2]. I think it would look cleaner if such a thing could be avoided when pushing simple changesets. Ok, after all, this one is rather cosmetical, though...

I'm in two minds about this. If there's a delay between request and
approval, it may be better to separate the original tested push and
the merge with the current state, so the original testing isn't lost.
Best to avoid it if possible though.

>
> Thanks and best regards
> Christoph
>
>
> [0] https://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-February/008663.html
> [1] http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/a854158a2c94
> [2] http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/aa5e4bedfa82
>
>


-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Web Site: http://fuseyism.com
Twitter: https://twitter.com/gnu_andrew_java
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222


More information about the jdk8u-dev mailing list