[RFR} [8u] JDK-8228440: TestAESCiphers tests fail with "access denied" trying to access ArrayUtil

Andrew John Hughes gnu.andrew at redhat.com
Fri Jul 19 17:53:58 UTC 2019



On 19/07/2019 18:46, Aleksey Shipilev wrote:
> On 7/19/19 6:16 PM, Andrew John Hughes wrote:
>> Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8228440/webrev.01/
> 
> *) It looks that test/java/util/Objects/CheckIndex.java is not in proper location now, should be
> somewhere in com/sun/... as well?
> 
> *) I do wonder if Preconditions is now the special-cased utility class, we could eliminate some
> unused methods and/or their extensive Javadocs.
> 
> Otherwise looks good. Let's hear what others think.
> 

On both points, I'm trying to minimise divergence from later versions.
While both may be appropriate for 8u independently (and I did consider
the first of these myself), they don't make any real function difference
and I think they'd just create unnecessary headaches if any future
patches touch these classes.
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew



More information about the jdk8u-dev mailing list