[RFR} [8u] JDK-8228440: TestAESCiphers tests fail with "access denied" trying to access ArrayUtil

[Aleksey Shipilev]

On 7/19/19 7:53 PM, Andrew John Hughes wrote:
> On 19/07/2019 18:46, Aleksey Shipilev wrote:
>> On 7/19/19 6:16 PM, Andrew John Hughes wrote:
>>> Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8228440/webrev.01/
>>
>> *) It looks that test/java/util/Objects/CheckIndex.java is not in proper location now, should be
>> somewhere in com/sun/... as well?
>>
>> *) I do wonder if Preconditions is now the special-cased utility class, we could eliminate some
>> unused methods and/or their extensive Javadocs.
>>
>> Otherwise looks good. Let's hear what others think.
> 
> On both points, I'm trying to minimise divergence from later versions.
> While both may be appropriate for 8u independently (and I did consider
> the first of these myself), they don't make any real function difference
> and I think they'd just create unnecessary headaches if any future
> patches touch these classes.

I understand, but once we forked those implementations, there are no "later version" anymore. These
are private implementations now, and the simpler they are, the better.

-- 
Thanks,
-Aleksey