[8u] RFR: backport of 8193830: Xalan Update: Xalan Java 2.7.2
Langer, Christoph
christoph.langer at sap.com
Mon Jun 3 20:52:01 UTC 2019
Hi Simon,
this looks good to me overall. Thanks for doing this work.
I'd rather opt for not doing unforced additional modifications in backports such as touching the additional indexOf in FunctionAvailableCall.java - but as it is so minor, it's ok for me to leave it.
I think, though, that you should update the Xalan version in THIRD_PARTY_README to 2.7.2 to follow the upstream update to xalan.md. And also update fImmutableVersion in jaxp/src/com/sun/org/apache/xerces/internal/impl/ to 2.7.2. (This facility does not exist upstream any more)
Best regards
Christoph
> -----Original Message-----
> From: jdk8u-dev <jdk8u-dev-bounces at openjdk.java.net> On Behalf Of
> Simon Tooke
> Sent: Freitag, 31. Mai 2019 18:19
> To: jdk8u-dev at openjdk.java.net
> Subject: [8u] RFR: backport of 8193830: Xalan Update: Xalan Java 2.7.2
>
> This backport doesn't seem to actually update Xalan, but it does fix
> xslt transforms in some locales.
>
> I had to modify the test code to run (successfully) in 8u, and I did
> change one indexOf(":") to indexOf(':') for consistency, but other than
> that it was a fairly clean port. Passes all the tests in javax.xml,
> including the new one.
>
> Issue: https://bugs.openjdk.java.net/browse/JDK-8193830
>
> Webrevs: http://cr.openjdk.java.net/~stooke/webrevs/jdk-8193830/
>
> (jaxp repo for fixes, jdk repo for new unit test)
>
> Is it good?
>
> -Simon
>
More information about the jdk8u-dev
mailing list